BDMS 147 & 114: update water levels transfer script & lexicon#167
Merged
Conversation
…ation-sample-field-transfer
…ation-sample-field-transfer
…ation-sample-field-transfer
…b.com/DataIntegrationGroup/NMSampleLocations into jab-observation-sample-field-transfer
Codecov Report✅ All modified and coverable lines are covered by tests.
|
Contributor
Author
|
a sample of what is logged from the water levels transfers |
Contributor
There was a problem hiding this comment.
Did you create this file, or was it generated?
Member
There was a problem hiding this comment.
This file was created by hand from NM_Aquifer. @jacob-a-brown did most of the heavy lifting, but I converted it into JSON.
| get_quad_name_from_point, | ||
| # get_state_from_point, | ||
| # get_county_from_point, | ||
| # get_quad_name_from_point, |
Contributor
There was a problem hiding this comment.
Please remove the commented-out code
Co-authored-by: Tyler Adam Martinez <tylermartinez@my.unt.edu>
Co-authored-by: Tyler Adam Martinez <tylermartinez@my.unt.edu>
jirhiker
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
transfers/waterlevels_transfer.pyneeded to be updated for the revisedobservation,sample,field_event,field_activity, andfield_event_contact_assocationtablescore/lexicon.jsonneeded to be updated for the contacts created from NM_Aquifer's WaterLevels tabletransfers/util.pytoservices/lexicon_mapper.pycaused circular importsHow
Implementation summary - the following was changed / added / removed:
MeasuredByin NM_Aquifer's WaterLevels tableobservation,sample,field_event,field_activity, andfield_event_contact_assocationtables in the correct orderlexicon.jsonif they existed in NM_Aquifer's WaterLevels tableField Event Participanttolexicon.jsonfor contacts who participate in field eventsLexiconMapperfromservices/lexicon_mapper.pytotransfers/util.pyNotes
Any special considerations, workarounds, or follow-up work to note?
MeasuredByto theContacttable will need to change.MeasuringAgency? Or other edge cases?